Advanced Call Spy v17.0.1.3 Released

Development
1

Advanced Call Spy v17.0.1.3 alpha is released.

This has about a half dozen bug fixes along with the improvements of:

  • PIN Sets can now be used
  • Spy Code extension can be edited post-creation.

From CLI:

fwconsole ma downloadinstall https://github.com/blazestudios97/advcallspy/releases/download/v17.0.1.3/advcallspy-17.0.1.3.tar.gz
fwconsole r

From Module Admin, use Upload Modules → Download (from web) and enter:
https://github.com/blazestudios97/advcallspy/releases/download/v17.0.1.3/advcallspy-17.0.1.3.tar.gz

3 Likes
2

Attempted an install of 17.0.1.3 on a virgin Tango system. Module install fails with

root@tangopbx5:~# fwconsole ma install advcallspy
Updating tables advcallspy_details, advcallspy_groups, advcallspy_group_extens...Done
Checking if default ChanSpy feature code is enabled.. Adding Advanced Call Spy default spy code 555 (ChanSpy). You must enable it for use.

In Advcallspy.class.php line 440:

  Undefined array key "pinset"

I resolved by adding a pinset definition to line 66 Advcallspy.class.php, but not 100% sure that’s the proper fix here.

            'spygroups' => '',
			'pinset' => '',
3

The pinsets module is a requirement, but is not set as a dependency in module.xml. Not having pinsets installed and enabled will throw whoops errors

	<depends>
		<module>pinsets ge 17.0.0</module>
	</depends>
1 Like
4

Strange, I did an install and update and didn’t catch that.

5

Yeah, I didn’t think about that.

6

@lgaetz Pushed a fix.

https://github.com/blazestudios97/advcallspy/releases/download/v17.0.1.4/advcallspy-17.0.1.4.tar.gz

7

Testing 17.0.1.4. Doing apply config in GUI looks clean, but running fwconsole r from bash shows error below. I don’t think I’ve ever seen that before where one worked and the other didn’t.

root@tangopbx5:/var/www/html/admin/modules# fwconsole r
Reload Started

In Advcallspy.class.php line 743:

  Undefined array key "restricted"

Brand new system with no extensions defined yet.

8

I found it, I’m just going to repush the .4 release in a few minutes.

1 Like
9

OK I just pushed the changes. I uninstalled my current .4 version and did another download and reload…tried from the cli too

root@tangopbx:/var/www/html/admin/modules/advcallspy# fwconsole r
Reload Started
Reload Complete
1 Like
10

Have not actually tested the spying, but spent a lot of time last night testing 17.0.1.4.B trying to break the install, uninstall, disable, delete, etc., trying to break the GUI options, looking over the generated dialplan and can’t find anything. Found some openpage bugs tho, so got that going for me which is nice.

Module still shows as unsigned on Tango, did you figure out how to resolve that key issue?

11

Are you referring to the big red alert that appears on the dashboard? It also tells me @billsimon’s module is unsigned as well. However, if you run fwconsole ma refreshsignatures it shows that the signature is Good. If you look at it through Module Admin it says the signature is good.

My previous problem was I didn’t make the key public, which I have done per @theJames help. Before I made it public, the signature showed as “couldn’t find on remote server” when doing a signature refresh and module admin listed it as unsigned. Those two problems are gone.

It’s been throwing that error on the dashboard since I installed the SMS Connector module while every place else says the SMS Connector module is good. I ignored that warning on the dashboard at first because of that for this module. It wasn’t until I saw the other places throwing errors that I figured I missed a step with my key.

Still haven’t figured out how to make that warning go away…even when I uninstall advcallspy during testing…that warning still shows for the SMS Connector on the dashboard.

root@tangopbx:~# fwconsole ma refreshsignatures
Getting Data from Online Server...
Done
Checking Signatures of Modules...
Checking advcallspy...
Good

SCR-20250619-ec4
SCR-20250619-ec41820×312 43.6 KB

12

Also, I would like to take a moment and thank @lgaetz for all the help in the QA and testing of this. It has been beyond helpful.

2 Likes
13

I have speculated that this happens after an install because whatever sounds this alarm is triggered before the signature verification process is done. If you clear the warning then it stays gone until the next update. Doesn’t happen in FreePBX 16, only 17. I have answered multiple tickets in github where people ask about this but I don’t have a solution and haven’t been motivated to dig down into it.

14

Are you seeing this on just straight up FreePBX v17 systems?

15

Yes and here are a couple tickets from others also.

16

From what I understand, they changed how they check for licenses now. I wonder if that has anything to do with it.

17

I have the same issue with dpviz.
freepbx.log throws this in the log each time the dashboard is loaded.

[freepbx.INFO]: [NOTIFICATION]-[freepbx]-[FW_TAMPERED] - You have 2 tampered files (Module "Dial Plan Vizualizer" signed by an invalid key.<br>Module: "Dial Plan Vizualizer", File: "module.sig check failed! Signed by unknown, untrusted key.") [] []

The dashboard does not show this error because I have suppressed/ killed it.

I believe you can sign your module with any string you like and the Module Admin page will say that the signature is good.

18

I don’t think so…

It’s beside the point though. The key I sign the SMS Connector module with has been cosigned by Sangoma with the FreePBX signing key so it should not be causing alerts on FreePBX. And it works fine on FreePBX 16. So something is different with 17.

19

It doesn’t. Already saw that when I signed it and then tampered with it.

20

I think this has to do with the license check changes they did, which is why people doing migrations were not have commercial modules restored because Sangoma saw the license on another system.